Skip to content

Commit

Permalink
Minor - Share widget: Adding X social media and updating Twitter logo (
Browse files Browse the repository at this point in the history
  • Loading branch information
Garneauma committed May 15, 2024
1 parent 37c1307 commit 4df2b3e
Show file tree
Hide file tree
Showing 5 changed files with 57 additions and 1 deletion.
22 changes: 22 additions & 0 deletions src/plugins/share/share-en.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,25 @@
</section>
</details>
</section>

<section>
<h2>With X instead of Twitter</h2>

<div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "x"], "pnlId": "pnl5a"}'></div>

<details>
<summary>View code</summary>
<pre class="wb-prettify"><code>&lt;div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "x"], "pnlId": "pnl5a"}'&gt;&lt;/div&gt;</code></pre>
</details>
</section>

<section>
<h2>When X and Twitter are defined</h2>
<p>When X and Twitter are both configured, only X will be displayed.</p>
<div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "twitter", "x"], "pnlId": "pnl5b"}'></div>

<details>
<summary>View code</summary>
<pre class="wb-prettify"><code>&lt;div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "twitter", "x"], "pnlId": "pnl5b"}'>&lt;/div></code></pre>
</details>
</section>
22 changes: 22 additions & 0 deletions src/plugins/share/share-fr.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,25 @@
</section>
</details>
</section>

<section>
<h2>Avec X au lieu de Twitter</h2>

<div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "x"], "pnlId": "pnl5a"}'></div>

<details>
<summary>Visualiser le code</summary>
<pre class="wb-prettify"><code>&lt;div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "x"], "pnlId": "pnl5a"}'&gt;&lt;/div&gt;</code></pre>
</details>
</section>

<section>
<h2>Lorsque X et Twitter sont définis</h2>
<p>Lorsque X et Twitter sont tous deux configurés, seul X sera affiché.</p>
<div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "twitter", "x"], "pnlId": "pnl5b"}'></div>

<details>
<summary>Visualiser le code</summary>
<pre class="wb-prettify"><code>&lt;div class="wb-share" data-wb-share='{"filter": ["email", "facebook", "linkedin", "twitter", "x"], "pnlId": "pnl5b"}'>&lt;/div></code></pre>
</details>
</section>
14 changes: 13 additions & 1 deletion src/plugins/share/share.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@ var componentName = "wb-share",
url: "https://www.tumblr.com/share/link?url={u}&amp;name={t}&amp;description={d}"
},
twitter: {
name: "Twitter",
name: "X",
url: "https://twitter.com/intent/tweet?text={t}&url={u}"
},
x: {
name: "X",
url: "https://twitter.com/intent/tweet?text={t}&url={u}"
},
yahoomail: {
Expand Down Expand Up @@ -192,6 +196,14 @@ var componentName = "wb-share",
keys.sort( function( x, y ) {
return wb.normalizeDiacritics( x ).localeCompare( wb.normalizeDiacritics( y ) );
} );

// If Twitter and X are both present, only keep X
if ( keys.includes( "twitter" ) && keys.includes( "x" ) ) {
keys = keys.filter( function( item ) {
return item !== "twitter";
} );
}

len = keys.length;

// Generate the panel
Expand Down
Binary file modified src/plugins/share/sprites/twitter.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/plugins/share/sprites/x.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 4df2b3e

Please sign in to comment.