Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of assets: "https://wet-boew.github.io/themes-dist" led to 404 breakage #23

Open
anthonyfok opened this issue Mar 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@anthonyfok
Copy link

anthonyfok commented Mar 11, 2021

Some websites relying on GCWeb theme broke as asset URLs such as https://wet-boew.github.io/themes-dist/GCWeb/css/theme.min.css went offline (404), see wet-boew/GCWeb#1792

Despite my comment there, in retrospect, I think the real issue is with wet-boew/gcweb-jekyll assuming the GCWeb theme asset files are https://wet-boew.github.io/themes-dist are public and permanent, when in fact they are not.

Setting assets: "https://wet-boew.github.io/themes-dist" in _config.yml, as what is done currently (see https://github.com/wet-boew/gcweb-jekyll/blob/master/_config.yml#L65), is very convenient, and eliminates the need for gcweb-jekyll to pull these files from wet-boew/GCWeb etc., but as today's breakage shows, seems rather unreliable.

Perhaps having these assets stored on the same server of end users' web sites would be a better idea? Or perhaps have those assets stored, with a versioned path, on a CDN for posterity, like how jQuery, Bootstrap etc.?

@anthonyfok anthonyfok changed the title Use of assets: "https://wet-boew.github.io/themes-dist" led to 404 breakage Use of assets: "https://wet-boew.github.io/themes-dist" led to 404 breakage Mar 11, 2021
@anthonyfok
Copy link
Author

I just noticed Issue #14 Sass files import from GCWeb.
Thank you for that!
Fixing #14 should solve this issue (#23) too.

@RobJohnston
Copy link

Or perhaps have those assets stored, with a versioned path, on a CDN for posterity

These files can be retrieved from GitHub via jsDelivr. The format is "/gh/user/repo@version/file.js".

For example:
https://cdn.jsdelivr.net/gh/wet-boew/themes-cdn@4.0.27-theme-gc-intranet/css/theme.min.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
GCWeb Jekyll bug triage
  
Needs triage
Development

No branches or pull requests

3 participants