Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/ website breakage due to upstream relocated GCWeb theme assets URLs #1

Closed
anthonyfok opened this issue Mar 12, 2021 · 0 comments
Closed

/ website breakage due to upstream relocated GCWeb theme assets URLs #1

anthonyfok opened this issue Mar 12, 2021 · 0 comments
Assignees
@anthonyfok
Labels
Bug Something isn't working Priority: Must Have Severity: Critical Task

Comments

@anthonyfok
Copy link
Collaborator

See upstream issues:

Apparently, the GCWeb theme assets were moved from https://wet-boew.github.io/themes-dist/GCWeb/ to https://wet-boew.github.io/themes-dist/GCWeb/GCWeb (Thanks to @HamidHabib's observation, see wet-boew/wet-boew#9060)

Some possible strategies:

  1. Include our own copy of the GCWeb theme asset files
  2. Use GCWeb theme files from jsDelivr CDN (Thanks @RobJohnston, Use of assets: "https://wet-boew.github.io/themes-dist" led to 404 breakage wet-boew/gcweb-jekyll#23 (comment))
  3. Tweak _config.yml (Thanks @jvanulde!)

Initial tests show the following minimal patch works to restore a local build of the (currently relatively simple) opendrr.github.io organization site.

--- a/_config.yml
+++ b/_config.yml
@@ -62,7 +62,7 @@ collections:
 analytics_adobe: ""
 analytics_google: ""
 analytics_google_anonymize_ip: ""
-assets: "https://wet-boew.github.io/themes-dist"
+assets: "https://wet-boew.github.io/themes-dist/GCWeb"
 baseurl: "" # set this to your GitHub project name
 css_inline: false # Will insert all styles into a single <style> block in the <head> element and remove the style <link> reference
 description:
--- a/_pages/index.md
+++ b/_pages/index.md
@@ -12,7 +12,7 @@
   permalink: /
   section: message
   stylesheets:
-    - href: "https://wet-boew.github.io/themes-dist/GCWeb/css/messages.min.css"
+    - href: "https://wet-boew.github.io/themes-dist/GCWeb/GCWeb/css/messages.min.css"
   subject:
     en: Government of Canada, services
     fr: Gouvernement du Canada, services

But more tests are needed for the /data and /documentation project sites.
@anthonyfok anthonyfok self-assigned this Mar 12, 2021
This was referenced Mar 12, 2021
Closed
Closed
@anthonyfok anthonyfok changed the title Website breakage due to upstream relocated GCWeb theme assets URLs top-level site breakage due to upstream relocated GCWeb theme assets URLs Mar 12, 2021
@anthonyfok anthonyfok changed the title top-level site breakage due to upstream relocated GCWeb theme assets URLs / site breakage due to upstream relocated GCWeb theme assets URLs Mar 12, 2021
@anthonyfok anthonyfok changed the title / site breakage due to upstream relocated GCWeb theme assets URLs / website breakage due to upstream relocated GCWeb theme assets URLs Mar 12, 2021
anthonyfok added a commit that referenced this issue Mar 12, 2021
@anthonyfok
Quick fix for breakage due to GCWeb theme assets relocation
33d40c1 
from https://wet-boew.github.io/themes-dist
to   https://wet-boew.github.io/themes-dist/GCWeb

Need to revisit later for a more robust fix.

Fixes #1
anthonyfok added a commit to anthonyfok/documentation that referenced this issue Mar 12, 2021
@anthonyfok
opendrr-platform-before.html: Fix links to GCWeb theme assets
48ed9b7 
due to upstream relocation
from https://wet-boew.github.io/themes-dist
to   https://wet-boew.github.io/themes-dist/GCWeb

This file was locally generated, hence the separate commit.

See also OpenDRR#6 and OpenDRR/opendrr.github.io#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonyfok anthonyfok

Labels
Bug Something isn't working Priority: Must Have Severity: Critical Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonyfok