New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust the list styles to accommodate MWS #2335
base: master
Are you sure you want to change the base?
Conversation
C'est fait. Merci! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline comments.
Pre-approved upon successful review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And see the top margin issue on our template
Fixed. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the requested change,
Note for myself regarding the next review: I will need to go through all the preceding comment to ensure they have been addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add/adjust the working example of ul.disc / ul.circle / ul.square
Thanks
Fait. Merci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a few editorial change, see my inline comment + you will need to apply the similar change to the French version.
And, let's remove the extra CSS class for when "disc", "circle", "square" is directly used on the unordered list element compared to when it is used on a generic container
Changes applied. Thanks |
The
ul
css most common classes can be applied on parent div too in order to accommodate MWS limitation