Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use R2U to install r packages [no version bump] #495

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

henrykironde
Copy link
Contributor

No description provided.

@henrykironde henrykironde force-pushed the rig-error branch 6 times, most recently from 6afa10b to f8d1170 Compare April 13, 2023 05:53
@henrykironde henrykironde changed the title Rig error r2u [no version bump] Use R2U to install r packages.[no version bump] Apr 16, 2023
@henrykironde henrykironde changed the title Use R2U to install r packages.[no version bump] Use R2U to install r packages. [no version bump] Apr 16, 2023
@henrykironde henrykironde changed the title Use R2U to install r packages. [no version bump] Use R2U to install r packages [no version bump] Apr 16, 2023
@henrykironde
Copy link
Contributor Author

  • Update DESCRIPTION contents
    we removed install-packages.R since we use DESCRIPTION to Install R dependencies

with the github.event.pull_request.head.sha we fetch the real last commit during a PR, rather than the temporary commit.

- uses: actions/checkout@v3
        with:
          # pull_request ref https://github.com/orgs/community/discussions/28474
          ref: ${{ github.event.pull_request.head.sha }}

Hence, we are removing the check on PR
LOG: ${{ github.event_name == 'pull_request' && '$(git log --no-merges --format=%B -n 1 HEAD^2)' || '$(git log --no-merges --format=%B -n 1 HEAD)' }}

  • With the above change, we need to confirm if Bump version section of the CI log displayed the correct commit after the PR merge.

@gmyenni
Copy link
Contributor

gmyenni commented Apr 17, 2023

Can you correct the title, authors and description to match: https://www.biorxiv.org/content/10.1101/332783v3.full
And the license to match the readme?

Setup r2u using https://eddelbuettel.github.io/r-ci/run.sh
sets ENV USE_BSPM=${USE_BSPM:-"TRUE"} and remove RSPM
actions/checkout@v3 should checkout real branch commits even on PR
ref: ${{ github.event.pull_request.head.sha }}
--no-pager, quit after getting log info
Use DESCRIPTION to Install R dependencies.
Update version in DESCRIPTION using desc::desc_set_version

Co-authored-by: Glenda <gmyenni@users.noreply.github.com>

fixes #482
Copy link
Contributor

@gmyenni gmyenni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tests aren't running? Not sure if that's because there are so many notes and warnings in the R CMD check before it gets to run the actual tests.

Where is the update_data step?

@henrykironde henrykironde force-pushed the rig-error branch 6 times, most recently from 3396b1d to cae33a4 Compare April 18, 2023 21:53
@henrykironde
Copy link
Contributor Author

I had missed update_data step. I have added it back and I made sure the tests run.

@gmyenni
Copy link
Contributor

gmyenni commented Apr 19, 2023

  • It looks like every Rscript step gets this warning about the bspm: Warning message: D-Bus service not found!
  • Do we need the R CMD check step? Because it isn't a package, it just creates a bunch of warnings and notes.

@gmyenni
Copy link
Contributor

gmyenni commented Apr 19, 2023

Also, the description in the the Description still needs to be updated. You can just use the abstract from the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants