Enable async bind for Go #932
Conversation
Also adds Status type.
sheepsteak
force-pushed
the
go-async-bind
branch
from
88e2cab
to
8918907
Compare
webview.go
Outdated
| StatusSuccess = 0 | ||
|
|
||
| // Binding call failed | ||
| StatusError = 1 |
There was a problem hiding this comment.
-1 was used previously but other bindings seemed to be using 1 to state an error.
| // f must be a function | ||
| // f must return either value and error or just error | ||
| // f must be a function that accepts an id string as the first argument, and | ||
| // then any other arguments that you want to pass from the JavaScript function. | ||
| Bind(name string, f interface{}) error |
There was a problem hiding this comment.
I really wanted to change this to something like f func(id string, params ...interface{}) but I'm not sure if that's any better to use.
webview.go
Outdated
| return errors.New("function may only return a value or a value+error") | ||
|
|
||
| if v.Type().NumIn() > 0 && v.Type().In(0).Kind() != reflect.String { | ||
| return errors.New("first argument must be a string for the request id") |
There was a problem hiding this comment.
At least this will give a warning about id string needing to be first argument.
|
Thank you for this PR. I hope someone who is more familiar with Go can review this but I can comment on a few things. The HTML/JS code in the example should be identical to the existing examples for other languages. If possible we should avoid breaking compatibility with existing code. If adding a Is there a standard naming convention for this kind of thing in Go or a best practice in this situation? I wonder if there is a way to avoid breaking compatibility while allowing |
|
@SteffenL I did a bit more research and I've come up with something better I think. Backwards compatibility is now preserved and the consumer has the option to return a channel now. They can use the channel to send a The only other way I can think of doing it is by just having the bind callback run as a goroutine itself and then the consumer can just take as long as they need (perhaps by using a It would be great to get someone else's opinion like you say. I also fixed the example to be identical to the C/C++ one. |
At the moment it's not possible to do async work in the function passed to
Bindin Go.I've attempted to change this to bring it more in line with how it works for C and C# in that the consumer has to callReturnwith a status and a result.I'm not sure if changing the existingBindand making a breaking change is the best way of doing this. Perhaps I should make this a new function calledBindAsyncor something? Anyway, let me know what you think and I can make any changes.I've enabled the
bindcallback to return achan. This keeps backward compatibility but allows the use of goroutines that can send aBindCallbackResultthrough it to signal they are finished.I've updated the
bind.goexample with an example of using this as requested in #929 too.