Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling linux window closing using terminate function #849

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enabling linux window closing using terminate function #849

wants to merge 2 commits into from

Conversation

LorenzKrause
Copy link

Fixes #588

noahboegli added a commit to noahboegli/webview_go that referenced this pull request Jan 7, 2024
@noahboegli
[BUGFIX] Applied webview/webview#849 locally
06038d5
@noahboegli
Copy link

noahboegli commented Jan 7, 2024 •
edited

Could we get a push on this ? Or are you open to other people opening an updated PR ?
I have applied your fix to a fork of weview/webview_go and it fixes the issue with terminate then destroy not closing the window.

@SteffenL SteffenL self-assigned this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SteffenL SteffenL

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why webview Destroy() does not close webview window in both Linux and Windows environments?
3 participants
@LorenzKrause @noahboegli @SteffenL