Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window_set_fullscreen Window API #449

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wusyong
Copy link

@wusyong wusyong commented Aug 17, 2020

This is the first attempt to introduce a window api structure start with setting fullscreen.
Users can get the window handle from webview_get_window() and use it with any window api with prefix of window_*.

@d1y
Copy link

d1y commented Aug 17, 2020

Thank you

@vikigenius
Copy link

Is there anything blocking this from merging ? This is a very nice feature to have.

@nothingismagick
Copy link
Contributor

Good question, I agree would be great to merge in. Any blockers @wusyong ?

@wusyong
Copy link
Author

wusyong commented Feb 1, 2021

It's probably not compatible with m1. I'll update it later.

@abemedia
Copy link
Member

Would be great to also have Go bindings for this.

@dumanhaydar
Copy link

When I try, I have this error :

In file included from webview.cc:3:
./webview.h:577:10: error: no matching function for call to 'objc_msgSend'

@dumanhaydar
Copy link

And on Windows:

c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: $WORK\b001\_x002.o: in function `_cgo_5d5d1491a383_Cfunc_window_set_fullscreen':
/tmp/go-build/cgo-gcc-prolog:248: undefined reference to `window_set_fullscreen'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants