[WIP] alias type and idl rpc succinct method format #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added PR #229 which includes only the rpc method succinct form support |
pkieltyka
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
RIDL rpc method succinct definition (see #229)
Additionally, this PR adds a new
aliaskeyword. The idea here is you can alias a type, and add the+meta annotations and use it anywhere in the schema. See the PR.However, although the parsing works for alias, I feel the issue with the implementation is that it adds a new "alias" type, and it means generators need to think about it. Instead, it would be better if the alias type was just sugar and expanded to the full form in the schema object, which wouldn't require any changes to the generators, and that is preferred.
As result, I'm going to create a new PR to split out the succinct and alias features.