Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix attachment unicodeError #758

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

criptocoko
Copy link

This is a fix to handle emails with attachments that have characters that are not in range(128), in this case we encode them in base64.

web/utils.py Outdated Show resolved Hide resolved
web/utils.py Outdated Show resolved Hide resolved
@iredmail
Copy link
Contributor

iredmail commented Mar 2, 2023

Hi @criptocoko,

As requested in #757, could you please show us code snippet to reproduce the issue?

@iredmail
Copy link
Contributor

iredmail commented Mar 4, 2023

Hi @cclauss, could you help check the black --check . issue in GitHub Actions result?
I ran the latest black version locally but it's all fine, not sure why it failed in GitHub Actions.

$ black --check .
All done! ✨ 🍰 ✨
29 files would be left unchanged.

@iredmail
Copy link
Contributor

iredmail commented Mar 4, 2023

By the way, this change looks good to me after checked source code of py encoders.encode_base64().

iredmail
iredmail previously approved these changes Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants