refactor: remove python2 compatible import usages #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
May 19, 2022
cclauss
reviewed
May 19, 2022
cclauss
reviewed
May 19, 2022
cclauss
reviewed
May 19, 2022
|
Sorry for the delay... Please rebase. |
|
Rebased :) |
|
LGTM |
cclauss
reviewed
Oct 16, 2022
| @@ -35,7 +36,7 @@ def runbasic(func, server_address=("0.0.0.0", 8080)): | |||
|
|
|||
| class WSGIHandler(SimpleHTTPRequestHandler): | |||
| def run_wsgi_app(self): | |||
| protocol, host, path, parameters, query, fragment = urlparse.urlparse( | |||
| protocol, host, path, parameters, query, fragment = urlparse( | |||
There was a problem hiding this comment.
This one is not quite right. The imports need to be modified to match web/db.py
There was a problem hiding this comment.
Sorry, I forget this for a long time, updated!
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Signed-off-by: AN Long <aisk1988@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.