Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for module autoreload breaking sessions #719

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for module autoreload breaking sessions #719

wants to merge 1 commit into from

Conversation

bobintetley
Copy link

See #717

@iredmail
Copy link
Contributor

iredmail commented Dec 6, 2021

LGTM

@anandology ?

iredmail
iredmail approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@iredmail iredmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the initial issue #438 with Python 3.8.9 and web.py-0.62 on macOS, it works with or without reload_mapping(). So let's revert the change to fix the session issues.

@iredmail
Copy link
Contributor

iredmail commented Mar 9, 2022

@cclauss Please help review this PR and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iredmail iredmail iredmail approved these changes

@anandology anandology Awaiting requested review from anandology

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobintetley @iredmail