Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

Use webpack 4 hooks #73

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Use webpack 4 hooks #73

wants to merge 1 commit into from

Conversation

ooflorent
Copy link

Use Tapable API to get rid of deprecation notices. This is a breaking change since this PR drops webpack 3 support.

@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #73 into next will increase coverage by 0.28%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #73      +/-   ##
==========================================
+ Coverage   95.06%   95.34%   +0.28%     
==========================================
  Files           4        4              
  Lines          81       86       +5     
  Branches       23       23              
==========================================
+ Hits           77       82       +5     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 94.73% <95.45%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41c10a...8a51991. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #73 into next will increase coverage by 0.28%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #73      +/-   ##
==========================================
+ Coverage   95.06%   95.34%   +0.28%     
==========================================
  Files           4        4              
  Lines          81       86       +5     
  Branches       23       23              
==========================================
+ Hits           77       82       +5     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 94.73% <95.45%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41c10a...8a51991. Read the comment docs.

@bloodyowl
Copy link

will this ever be merged?

@awmackowiak
Copy link

Hey guys. I have this same question as @bloodyowl . Will this ever be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants