Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

refactor: i18n Webpack Plugin Webpack 4.x compatibility #68

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Dec 5, 2017

  • Fixes for Webpack 4.x
  • Drops support for NodeJS 4.x
  • Sets minimum peerDep to Webpack 3.x

BREAKING CHANGE: Sets engines to "node": ">= 6.9.0 || >= 8.9.0"
BREAKING CHANGE: Drops support for Webpack v2.x

@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files           4        4           
  Lines          81       81           
  Branches       23       23           
=======================================
  Hits           77       77           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9c7d5...c41c10a. Read the comment docs.

@joshwiens joshwiens self-assigned this Dec 5, 2017
@joshwiens joshwiens changed the title [WIP] i18n Webpack Plugin v2 refactor: i18n Webpack Plugin Webpack 4.x compatibility Dec 5, 2017
@MrStarktastic
Copy link

Any update on when this is gonna be merged into master?
I'm asking due to a warning I'm getting when using webpack 4:
DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead
Tracing the deprecation warning shows that it originates from I18nPlugin.apply

@mistadikay
Copy link

mistadikay commented May 21, 2018

Guys, do you need any help with this one?

@adriangalera
Copy link

waiting for this PR to be merged

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files           4        4           
  Lines          81       81           
  Branches       23       23           
=======================================
  Hits           77       77           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9c7d5...c41c10a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants