Add a Symfony Serializer bridge #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function decode($data, $format, array $context = array()) | ||
| { | ||
| $schema = isset($context['schema']) ? $context['schema'] : null; |
There was a problem hiding this comment.
Is it preferable to use json_schema, to be compatible with a xml serializer with a schema context option ?
|
ping @webmozart |
|
@webmozart any chance to get this PR merged? |
|
Hi @dunglas, thanks for your PR! :) Sorry for not replying any sooner. Do you really think this belongs here and not rather in Symfony's component? This library is a very low-level library, while the serializer is a bit higher-level. I believe that higher-level libraries should contain bridges to support different lower-level libraries, but not the other way around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use your Encoder with the Symfony Serializer.