Add PHP extensions check to installer #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I agree with what you've done here, I think we need to tweak the approach. The phpExtCheck method should not be embedded in the PHP here. Ideally, it would be a method on the installer class or similar. Or - failing that - it would be in the main_functions.php file to keep it with the others. (Also, I'm sorry I didn't respond to this sooner.. I didn't get a notification that you had updated it.) |
|
I agree that phpExtCheck should not be embedded. But I suppose it's up to you to choose the best place for the method. If you want it on the installer class, where in the tree the Installer.class.php should be located? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #289