flagged a bunch of todo items throughout the system for later cleanup

web2project · Sep 8, 2013 · ebc2c2e · ebc2c2e
1 parent 6e4c677
commit ebc2c2e
Show file tree

Hide file tree

Showing 153 changed files with 241 additions and 69 deletions.
diff --git a/classes/w2p/Authenticators/PostNuke.class.php b/classes/w2p/Authenticators/PostNuke.class.php
@@ -4,6 +4,7 @@
  * request. This needs to be extracted and verified.
  *
  * @package     web2project\authenticators
+ * @todo    remove
  */
 
 class w2p_Authenticators_PostNuke extends w2p_Authenticators_Base

diff --git a/classes/w2p/Core/CAppUI.class.php b/classes/w2p/Core/CAppUI.class.php
@@ -4,6 +4,8 @@
  *
  * @package     web2project\core
  * @author      Andrew Eddie <eddieajau@users.sourceforge.net>
+ *
+ * @todo    refactor to w2p/System/AppUI
  */
 
 class w2p_Core_CAppUI

diff --git a/classes/w2p/Core/Config.class.php b/classes/w2p/Core/Config.class.php
@@ -1,7 +1,8 @@
 <?php
-
 /**
  * @package     web2project\core
+ *
+ * @todo    refactor to w2p/System/Config
  */
 
 class w2p_Core_Config extends w2p_Core_BaseObject

diff --git a/classes/w2p/Core/Dispatcher.class.php b/classes/w2p/Core/Dispatcher.class.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * This is the Dispatcher used for cross-module communications and heavily
  * based on http://dustint.com/post/38/building-a-php-publish-subscribe-system
@@ -8,6 +7,8 @@
  * @package     web2project\core
  * @author      Dustin Thomson <dustin@dustint.com>
  * @author      Keith Casey (maintainer) <caseydk@sourceforge.net>
+ *
+ * @todo    refactor to w2p/System/Dispatcher
  */
 
 class w2p_Core_Dispatcher

diff --git a/classes/w2p/Core/Event.class.php b/classes/w2p/Core/Event.class.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * This is the Dispatcher used for cross-module communications and heavily
  * based on http://dustint.com/post/38/building-a-php-publish-subscribe-system
@@ -8,7 +7,10 @@
  * @package     web2project\core
  * @author      Dustin Thomson <dustin@dustint.com>
  * @author      Keith Casey (maintainer) <caseydk@sourceforge.net>
+ *
+ * @todo    refactor to w2p/System/Event
  */
+
 class w2p_Core_Event {
 	/**
 	 * The name of the resource publishing this event

diff --git a/classes/w2p/Core/EventQueue.class.php b/classes/w2p/Core/EventQueue.class.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * The event queue uses the table event_queue to manage
  * event notifications and other timed events, as well as
@@ -9,8 +8,8 @@
  * @copyright   (c) 2005, dotproject team
  * @copyright   (c) 2007-2013 web2project team
  *
- * @todo        TODO: This can probably be converted to extend the
- * w2p_Core_BaseObject and just get rid of a bunch of this code. ~ dkc 28 Oct 2012
+ * @todo    This can probably be converted to extend the w2p_Core_BaseObject and just get rid of a bunch of this code. ~ dkc 28 Oct 2012
+ * @todo    refactor to w2p/System/EventQueue
  */
 
 class w2p_Core_EventQueue {

diff --git a/classes/w2p/Core/HookHandler.class.php b/classes/w2p/Core/HookHandler.class.php
@@ -7,6 +7,8 @@
  *
  * @package     web2project\core
  * @author      Keith Casey <caseydk@sourceforge.net>
+ *
+ * @todo    refactor to w2p/System/HookHandler
  */
 
 class w2p_Core_HookHandler

diff --git a/classes/w2p/Core/ListenerInterface.class.php b/classes/w2p/Core/ListenerInterface.class.php
@@ -7,6 +7,8 @@
  * @package     web2project\core
  * @author      Dustin Thomson <dustin@dustint.com>
  * @author      Keith Casey (maintainer) <caseydk@sourceforge.net>
+ *
+ * @todo    refactor to w2p/System/ListenerInterface
  */
 
 interface w2p_Core_ListenerInterface

diff --git a/classes/w2p/Core/Module.class.php b/classes/w2p/Core/Module.class.php
@@ -1,7 +1,8 @@
 <?php
-
 /**
  * @package     web2project\core
+ *
+ * @todo    refactor to w2p/System/Module
  */
 
 class w2p_Core_Module extends w2p_Core_BaseObject {

diff --git a/classes/w2p/Core/Preferences.class.php b/classes/w2p/Core/Preferences.class.php
@@ -2,11 +2,10 @@
 /**
  * This is the core preferences object that runs both the default and User-based preferences.
  *
- * @package     web2project\core 
- */
-/**
  * @package     web2project\core
- * @todo        TODO: couldn't this just extend the BaseObject?
+ *
+ * @todo    refactor to w2p/System/Preferences
+ * @todo    couldn't this just extend the BaseObject?
  */
 class w2p_Core_Preferences {
     /** This is the user_id */

diff --git a/classes/w2p/Core/Setup.class.php b/classes/w2p/Core/Setup.class.php
@@ -1,9 +1,10 @@
 <?php
-
 /**
  * @package     web2project\core
  *
  * @abstract
+ *
+ * @todo    refactor to w2p/System/Setup
  */
 
 abstract class w2p_Core_Setup {

diff --git a/classes/w2p/Core/UpgradeManager.class.php b/classes/w2p/Core/UpgradeManager.class.php
@@ -1,6 +1,8 @@
 <?php
 /**
  * @package     web2project\core
+ *
+ * @todo    refactor to w2p/System/UpgradeManager
  */
 
 class w2p_Core_UpgradeManager {

diff --git a/modules/admin/do_perms_aed.php b/modules/admin/do_perms_aed.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    refactor to use a core controller
 
 $del = (int) w2PgetParam($_POST, 'del', 0);
 

diff --git a/modules/admin/do_user_aed.php b/modules/admin/do_user_aed.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    refactor to use a core controller
 
 $del = (int) w2PgetParam($_POST, 'del', 0);
 

diff --git a/modules/admin/do_userrole_aed.php b/modules/admin/do_userrole_aed.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    refactor to use a core controller
 
 $del = (int) w2PgetParam($_POST, 'del', 0);
 

diff --git a/modules/admin/users.class.php b/modules/admin/users.class.php
@@ -1,7 +1,11 @@
 <?php
-
 /**
  * @package     web2project\modules\core
+ *
+ * @todo    refactor modules/admin to modules/users
+ * @todo    new query object
+ * @todo    refactor static methods
+ * @todo    remove declarations before the class
  */
 
 $utypes = w2PgetSysVal('UserType');

diff --git a/modules/admin/view.php b/modules/admin/view.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
     die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 $user_id = (int) w2PgetParam($_GET, 'user_id', 0);
 

diff --git a/modules/admin/vw_usr.php b/modules/admin/vw_usr.php
@@ -2,6 +2,8 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
+// @todo    remove database query
 
 global $AppUI;
 

diff --git a/modules/admin/vw_usr_log.php b/modules/admin/vw_usr_log.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 $date_reg = date('Y-m-d');
 $start_date = intval($date_reg) ? new w2p_Utilities_Date(w2PgetParam($_REQUEST, 'log_start_date', date('Y-m-d'))) : null;

diff --git a/modules/admin/vw_usr_perms.php b/modules/admin/vw_usr_perms.php
@@ -2,6 +2,8 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
+// @todo    remove database query
 
 global $AppUI, $user_id;
 

diff --git a/modules/admin/vw_usr_roles.php b/modules/admin/vw_usr_roles.php
@@ -1,9 +1,10 @@
 <?php
-global $AppUI, $user_id, $user_name, $canEdit, $canDelete, $tab;
-
 if (!defined('W2P_BASE_DIR')) {
-	die('You should not access this file directly.');
+    die('You should not access this file directly.');
 }
+// @todo    convert to template
+
+global $AppUI, $user_id, $user_name, $canEdit, $canDelete, $tab;
 
 $perms = &$AppUI->acl();
 $user_roles = $perms->getUserRoles($user_id);

diff --git a/modules/admin/vw_usr_sessions.php b/modules/admin/vw_usr_sessions.php
@@ -2,6 +2,8 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
+// @todo    remove database query
 
 global $AppUI, $w2Pconfig, $canEdit, $canDelete, $stub, $where, $orderby;
 

diff --git a/modules/calendar/addedit.php b/modules/calendar/addedit.php
@@ -2,6 +2,8 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
+
 global $AppUI, $cal_sdf;
 $AppUI->loadCalendarJS();
 

diff --git a/modules/calendar/calendar.class.php b/modules/calendar/calendar.class.php
@@ -1,7 +1,11 @@
 <?php
-
 /**
  * @package     web2project\modules\core
+ *
+ * @todo    refactor to modules/events
+ * @todo    new query object
+ * @todo    refactor static methods
+ * @todo    remove declarations before the class
  */
 
 $event_filter_list = array('my' => 'My Events', 'own' => 'Events I Created', 'all' => 'All Events');

diff --git a/modules/calendar/clash.php b/modules/calendar/clash.php
@@ -2,6 +2,8 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
+
 global $AppUI, $cal_sdf;
 $AppUI->loadCalendarJS();
 

diff --git a/modules/calendar/companies_tab.view.events.php b/modules/calendar/companies_tab.view.events.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 global $AppUI, $company_id;
 

diff --git a/modules/calendar/day_view.php b/modules/calendar/day_view.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 // check permissions for this record
 $perms = &$AppUI->acl();

diff --git a/modules/calendar/do_event_aed.php b/modules/calendar/do_event_aed.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    refactor to use a core controller
 
 $del = (int) w2PgetParam($_POST, 'del', 0);
 

diff --git a/modules/calendar/index.php b/modules/calendar/index.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 // check permissions for this record
 $perms = &$AppUI->acl();

diff --git a/modules/calendar/projects_tab.view.events.php b/modules/calendar/projects_tab.view.events.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 global $AppUI, $project_id;
 

diff --git a/modules/calendar/view.php b/modules/calendar/view.php
@@ -2,11 +2,10 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 $event_id = (int) w2PgetParam($_GET, 'event_id', 0);
 
-
-
 $event = new CEvent();
 $event->event_id = $event_id;
 

diff --git a/modules/calendar/vw_day_events.php b/modules/calendar/vw_day_events.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 global $this_day, $first_time, $last_time, $company_id, $event_filter, $event_filter_list, $AppUI;
 

diff --git a/modules/calendar/vw_day_tasks.php b/modules/calendar/vw_day_tasks.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 global $this_day, $first_time, $last_time, $company_id, $m, $a;
 

diff --git a/modules/calendar/week_view.php b/modules/calendar/week_view.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 // check permissions for this record
 $perms = &$AppUI->acl();

diff --git a/modules/calendar/year_view.php b/modules/calendar/year_view.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 // check permissions for this record
 $perms = &$AppUI->acl();

diff --git a/modules/companies/companies.class.php b/modules/companies/companies.class.php
@@ -3,7 +3,9 @@
 /**
  * @package     web2project\modules\core
  *
- * @todo Move the 'address' fields to a generic table
+ * @todo    Move the 'address' fields to a generic table
+ * @todo    new query object
+ * @todo    refactor static methods
  */
 
 class CCompany extends w2p_Core_BaseObject {

diff --git a/modules/contacts/addedit.php b/modules/contacts/addedit.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 $contact_id = (int) w2PgetParam($_GET, 'contact_id', 0);
 $company_id = (int) w2PgetParam($_GET, 'company_id', 0);

diff --git a/modules/contacts/contacts.class.php b/modules/contacts/contacts.class.php
@@ -2,6 +2,9 @@
 
 /**
  * @package     web2project\modules\core
+ *
+ * @todo    new query object
+ * @todo    refactor static methods
  */
 
 class CContact extends w2p_Core_BaseObject

diff --git a/modules/contacts/csvexport.php b/modules/contacts/csvexport.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 $canRead = canView('contacts');
 if (!$canRead) {

diff --git a/modules/contacts/select_contact_company.php b/modules/contacts/select_contact_company.php
@@ -2,6 +2,7 @@
 if (!defined('W2P_BASE_DIR')) {
 	die('You should not access this file directly.');
 }
+// @todo    convert to template
 
 $table_name = w2PgetParam($_GET, 'table_name', 'companies');
 $company_id = (int) w2PgetParam($_GET, 'company_id', 0);