webnn: Use TFLite for CPU execution on Linux #46213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5532576
branch
from
b3eaed6
to
1b99ce7
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5532576
branch
6 times, most recently
from
3dd0cc1
to
ac91f48
Compare
This CL primarily does two things:
1. Use TFLite backend (instead of XNNPACK) on Linux for "cpu" contexts
2. Refactor the existing Virtual Test Suite on Linux to run "cpu"
tests now that the "gpu" workaround is no longer needed to target
the TFLite backend
Note that - assuming TFLite-on-CPU behaves the same across platforms -
this "cpu" Virtual Test Suite and the corresponding expectations will
be re-used as other backends (or at least Windows) migrate "cpu"
context execution to TFLite in follow-up CLs
Before (on Linux):
- using a "cpu" context targets the XNNPACK backend in the renderer
- using a "gpu" context targets the TFLite backend in
//services (which currently runs on CPU anyways)
After (on Linux):
- using either a "cpu" or "gpu" context targets the TFLite backend in
//services
This opens the door for TFLite to truly target the GPU if instructed,
and gets us one step closer to removing the XNNPACK backend
Bug: 325612086
Change-Id: I421d97b7d91b604afbfb3c8aa71b55a5bc78bd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532576
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1300171}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5532576
branch
from
ac91f48
to
c0dd29b
Compare
wpt-pr-bot
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL primarily does two things:
tests now that the "gpu" workaround is no longer needed to target
the TFLite backend
Note that - assuming TFLite-on-CPU behaves the same across platforms -
this "cpu" Virtual Test Suite and the corresponding expectations will
be re-used as other backends (or at least Windows) migrate "cpu"
context execution to TFLite in follow-up CLs
Before (on Linux):
//services (which currently runs on CPU anyways)
After (on Linux):
//services
This opens the door for TFLite to truly target the GPU if instructed,
and gets us one step closer to removing the XNNPACK backend
Bug: 325612086
Change-Id: I421d97b7d91b604afbfb3c8aa71b55a5bc78bd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532576
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1300171}