Let document.caretPositionFromPoint work correctly in text control. #46211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5531199
branch
2 times, most recently
from
f64c1b4
to
04b6a16
Compare
If the point is inside input/text area element, the `CaretPosition` should have `offsetNode` pointing to the text control element instead of the inner editor element inside the user-agent shadow tree. The behavior is also defined in step 4 of the spec[1]. [1]: https://drafts.csswg.org/cssom-view/#dom-document-caretpositionfrompoint Bug: 41487363 Change-Id: I1c024bdf6ce9620905a28487c8c91383f2086a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5531199 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1301622}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5531199
branch
from
04b6a16
to
e93dfa7
Compare
wpt-pr-bot
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the point is inside input/text area element, the
CaretPositionshould have
offsetNodepointing to the text control element insteadof the inner editor element inside the user-agent shadow tree.
The behavior is also defined in step 4 of the
spec1.
Bug: 41487363
Change-Id: I1c024bdf6ce9620905a28487c8c91383f2086a54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5531199
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Sanket Joshi <sajos@microsoft.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1301622}