Move page margin handling over to Blink. #46205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5526464
branch
8 times, most recently
from
e4b4c63
to
364f93b
Compare
Remove the margin handling code from PrintRenderFrameHelper (used by the actual browser) and SpoolPagesWithBoundariesForTesting() (web tests). This allows @page backgrounds to cover the entire page box, including the margin area. Tests included. This CL also paves the road for implementing @page margin boxes (such as author-specified headers and footers), which was the main objective anyway. The fact that Blink is now responsible for the entire page box means that the code that deals with shrinking / centering paginated content to fit the target paper also has to be moved over to Blink. WebPrintPageDescription still provides margin info for each page. Although PrintRenderFrameHelper no longer needs to position the page area within the page box based on margins, the margins are still needed in order to figure out if there's enough room for UA-generated headers and footers. By moving all of this into Blink, it will be rather straight-forward to add web tests for page fitting, rather than writing clunky PrintRenderFrameHelper component browser tests for it. Will follow up with a CL for this. Three page-orientation tests now start passing. The code in SpoolPagesWithBoundariesForTesting() didn't add margin translation at the correct time when rotating. The margins are no longer added there, so the problem is gone. Bug: 40286153, 40341678 Change-Id: I418b2e08ed76b297ea5d5fc223545b52b3e9b09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526464 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300225}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5526464
branch
from
364f93b
to
5293e2b
Compare
wpt-pr-bot
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the margin handling code from PrintRenderFrameHelper (used by the
actual browser) and SpoolPagesWithBoundariesForTesting() (web tests).
This allows @page backgrounds to cover the entire page box, including
the margin area. Tests included.
This CL also paves the road for implementing @page margin boxes (such as
author-specified headers and footers), which was the main objective
anyway.
The fact that Blink is now responsible for the entire page box means
that the code that deals with shrinking / centering paginated content to
fit the target paper also has to be moved over to Blink.
WebPrintPageDescription still provides margin info for each page.
Although PrintRenderFrameHelper no longer needs to position the page
area within the page box based on margins, the margins are still needed
in order to figure out if there's enough room for UA-generated headers
and footers.
By moving all of this into Blink, it will be rather straight-forward to
add web tests for page fitting, rather than writing clunky
PrintRenderFrameHelper component browser tests for it. Will follow up
with a CL for this.
Three page-orientation tests now start passing. The code in
SpoolPagesWithBoundariesForTesting() didn't add margin translation at
the correct time when rotating. The margins are no longer added there,
so the problem is gone.
Bug: 40286153, 40341678
Change-Id: I418b2e08ed76b297ea5d5fc223545b52b3e9b09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526464
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300225}