De-flake native-popup-with-datalist #46195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to reproduce the flake which was happening because sometimes the button was still focused. I fixed it by blurring the focused element and adding a rAF. Fixed: 334122678 Change-Id: Iede088900b888ab32c3a9554d5c6fc83b980ccc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530688 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300308}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5530688
branch
from
365f0dd
to
ae927f3
Compare
wpt-pr-bot
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the flake which was happening because sometimes
the button was still focused. I fixed it by blurring the focused element
and adding a rAF.
Fixed: 334122678
Change-Id: Iede088900b888ab32c3a9554d5c6fc83b980ccc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530688
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300308}