Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WPT logo size differences #46186

Merged
merged 1 commit into from May 21, 2024

Conversation

mosaadm
Copy link
Contributor

@mosaadm mosaadm commented May 9, 2024

Fix for #19326
I changed the 5 svg files to be exactly the same code only different is fill='color' which is different depending on color needed and the files with background have one extra line which is a rect that is filled with background color

// second line in files is the one for background color
<rect x="0" y="0" fill="#003C56" width="398" height="340"/>  

Files without background were not changed as they are already the same size

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

@foolip
Copy link
Member

foolip commented May 10, 2024

@mosaadm can you say how you made the changes? Do the different variants all have exactly the same size and path data now?

@mosaadm
Copy link
Contributor Author

mosaadm commented May 10, 2024

@mosaadm can you say how you made the changes? Do the different variants all have exactly the same size and path data now?

@foolip I updated PR description, basically i just copy-pasted code fromwpt-logo-darkblue.svg and changed the colors

@foolip
Copy link
Member

foolip commented May 21, 2024

Thank you @mosaadm! It looks like the path data in all of the files are the same now, so I'll go ahead and merge this.

@foolip foolip merged commit dba116b into web-platform-tests:master May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants