added timing constructor test #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert.equal(player.currentTime, 0); | ||
| tick(300); | ||
| assert.equal(player.startTime, 300); // why does this pass? the anim is running? | ||
| assert.equal(player.currentTime, 300, 'after 300ms tick, currentTime should be 300ms'); // this fails -- what, what? |
There was a problem hiding this comment.
The animation was pending until 300, I'd expect that it's currentTime is actually 0 in this case?
There was a problem hiding this comment.
After all, it's start time is 300 per line 19.
There was a problem hiding this comment.
I've fixed this behaviour with feedback on how tick works. The test is still broken though :)
Conflicts: test/js/animation-constructor.js
| assert.equal(player.currentTime, 300); | ||
|
|
||
| timing.iterations = 0.5; | ||
| animation.timing.iterations = 0.5; |
There was a problem hiding this comment.
FYI these don't work because we don't yet support these maxifill feature (exposed timing, modifiable timing). They're not on the roadmap for the m39 release.
Conflicts: test/js/timing.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some failing tests around timing.