[Not for landing] More group pause tests #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis fails because the tests fail. |
|
Link to bug? |
Added child-player-pause-after-finish-bug.js tick-after-pause-bug.js group-player-skeleton-tests.js temporarily while I work on these tests and related bugs. They need to be removed and unplugged later. Added some comments to group-player.js that need to be cleaned up before landing. Bugs found: Calling pause->play->tick causes the tick to update the currentTime of the player (which it should not), but pause->tick->play->tick behaves as expected (i.e. the first tick after play restores a playing state, but doesn't touch the currentTime). Pausing a group when some of its children are finished and then playing it again causes the finished children to seek to a currentTime beyond their total duration.
rjwright
force-pushed
the
GroupsTests
branch
from
5c26b4f
to
94788fd
Compare
rjwright
changed the title
|
Related: #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these fail. There is a bug.