Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: translate CRI container state #3899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bboreham
Copy link
Collaborator

Use values consistent with what we use for Docker.
This avoids seeing all containers as 'stopped', as noted at #3880.

Use values consistent with what we use for Docker.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@CVilinsky
Copy link

Hi, can you elaborate on that?
I changed the ds.yaml as you mentioned, and now I can see the containers but they are all 'stopped'.

@bboreham
Copy link
Collaborator Author

This is a proposed change to the Go code to fix the issue. Are you are able to download this branch and build your own container?

@CVilinsky
Copy link

Yes, I have cloned your branch, but still I still can't see any containers.
I have also made the changes you've noted in #3880 , because my container-runtime is 'containerd'.

@ghost
Copy link

ghost commented Mar 17, 2023

I can confirm that this fixes seeing all containers as 'stopped', but I wonder if it's useful for anything. When I click on a container the side widget only shows 'sha256 ... not found' and the pod and host the container is running in. 'by DNS name' and 'by image' is still empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants