Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all unnecessary binding in HTML #396

Closed
MatthijsSmets opened this issue May 2, 2024 · 0 comments · Fixed by #413
Closed

Remove all unnecessary binding in HTML #396

MatthijsSmets opened this issue May 2, 2024 · 0 comments · Fixed by #413
Assignees
@MarkvdVorst
Labels
Style Styling of code

Comments

@MatthijsSmets
Copy link
Contributor

Attributes like title and icon are strings, right now they are entered as if they're are variables and then quoted as a string, these need to be replaced like so:

<app-button [icon]="'fa fa-play'" [title]="'Run All'"></app-button>
<app-button icon="fa fa-play" title="Run All"></app-button>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkvdVorst MarkvdVorst

Labels
Style Styling of code
Projects
Ladybug component refactoring
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all unnecessary binding in HTML wearefrank/ladybug-frontend
3 participants
@philipsens @MarkvdVorst @MatthijsSmets