Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor updatePath method in test.component.ts #393

Open
MatthijsSmets opened this issue Apr 30, 2024 · 2 comments · May be fixed by #420
Open

Refactor updatePath method in test.component.ts #393

MatthijsSmets opened this issue Apr 30, 2024 · 2 comments · May be fixed by #420
Assignees
@MarkvdVorst
Labels
Style Styling of code

Comments

@MatthijsSmets
Copy link
Contributor

MatthijsSmets commented Apr 30, 2024 •
edited

In the test component, update path and the form that triggers it should be refactored to use Angular's built in form support, instead of using query selector and value={{}}. This is not the only place where this happens all places where a querySelector is used can be replaced with the angular way.
@MatthijsSmets MatthijsSmets mentioned this issue May 2, 2024
Merged
@philipsens philipsens added the Style Styling of code label May 2, 2024
@MarkvdVorst MarkvdVorst self-assigned this May 29, 2024
@MarkvdVorst
Copy link
Contributor

MarkvdVorst commented May 29, 2024 •
edited

The queryselector already gets replaced with the angular solution in the PR for issue #409

@MarkvdVorst
Copy link
Contributor

The use of value={{}} example gets fixed in the PR for issue #396

@MarkvdVorst MarkvdVorst linked a pull request Jun 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkvdVorst MarkvdVorst

Labels
Style Styling of code
Projects
Ladybug component refactoring
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor updatepath method in test component wearefrank/ladybug-frontend
3 participants
@philipsens @MarkvdVorst @MatthijsSmets