Basic unit tests for all sample-migration screens #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cmathew
commented
Sep 27, 2023
cmathew
commented
- mock toolbar helper in tests
- use setContentScreen where possible
- configure Robolectric via properties file where possible
cmathew
commented
Sep 27, 2023
| sdk=28 | ||
| application=com.wealthfront.magellan.sample.migration.TestSampleApplication |
There was a problem hiding this comment.
Robolectric will pick this up automatically since it's looking out for classes named "TestBlahApplication", but good to be explicit anyways
cmathew
commented
Sep 27, 2023
| @@ -12,7 +13,8 @@ import com.wealthfront.magellan.navigation.NavigationPropagator | |||
| * Ideally, this dependency is provider by dependency injection and configured so that the views are cleaned up when the activity | |||
| * is destroyed with the help of (subcomponents & custom scopes)[https://dagger.dev/dev-guide/subcomponents]. | |||
| */ | |||
| object ToolbarHelper : LifecycleAwareComponent(), NavigationListener { | |||
| @OpenForMocking | |||
| class ToolbarHelper : LifecycleAwareComponent(), NavigationListener { | |||
There was a problem hiding this comment.
convert to instance so it can be injected, and therefore easily mocked in test
kyeungk
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.