Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-type header works like the accept header, with support for arrays of values #128

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Content-type header works like the accept header, with support for arrays of values #128

wants to merge 3 commits into from

Commits on May 25, 2016

  1. Content-type header works like the accept header, with support for ar… 

    …rays of values

The content-type header did not support an array of header values (for example headers['Content-Type'] = ['application/json', 'text/json', 'application/xml', 'text/xml', 'application/x-www-form-urlencoded'];) it would just produce a single string (i.e. headers['Content-Type'] = 'application/json, text/json, application/xml, text/xml, application/x-www-form-urlencoded;

Which is incorrect, it should be an array as Accept does. Refactored out the code from accept to a function (produceHeaderKeyValue) and changed Accept & Content-Type to use that one function.
    @rmaclean
    rmaclean committed May 25, 2016
    Configuration menu
    Copy the full SHA
    400a6f7 View commit details
    Browse the repository at this point in the history

  2. Strings to single quotes as per CircleCI

    @rmaclean
    rmaclean committed May 25, 2016
    Configuration menu
    Copy the full SHA
    8101574 View commit details
    Browse the repository at this point in the history

  3. Adding missing semicolon

    @rmaclean
    rmaclean committed May 25, 2016
    Configuration menu
    Copy the full SHA
    60945e8 View commit details
    Browse the repository at this point in the history