direwolf.desktop: remove xterm hard-coding, fix icon #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes wb2osz#308 Per the [desktop entry specification](https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys), all that should be needed to run direwolf in the default terminal of a user's system should be setting `Terminal=true`. Per the [xdg icon theme specification](https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#icon_lookup), the `Icon` key in a desktop file should only include the basename of the icon's filename, not include the extension.
classabbyamp
force-pushed
the
fix-desktop-entry
branch
from
f9ffec7
to
ea68a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #308
Per the desktop entry specification, all that should be needed to run direwolf in the default terminal of a user's system should be setting
Terminal=true.Per the xdg icon theme specification, the
Iconkey in a desktop file should only include the basename of the icon's filename, not the extension.