Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dwgpsd.c #331

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

Thomas-McCarthy
Copy link

Fix for Issue #330

An incompatibility was introduced again when using gpsd api 11 from gpsd: 3.22.1~dev (revision release-3.22-332-g743585cc3)
Increasing the
Changing GPSD_API_MAJOR_VERSION > 11 to 12 solves this.

Fix for Issue wb2osz#330 

An incompatibility was introduced again when using gpsd api 11 from gpsd: 3.22.1~dev (revision release-3.22-332-g743585cc3)
Increasing the
Changing GPSD_API_MAJOR_VERSION > 11 to 12 solves this.
@wb2osz
Copy link
Owner

wb2osz commented Apr 21, 2021

Did you actually run it successfully or declare victory when it compiled OK?

There was at least one other case where simply accepting the higher API version resulted in successful compilation but it did not run properly. Additional API version specific changes were necessary. You will notice the code is littered with numerous places trying to keep up with all the incompatible changes made to the API.

@Thomas-McCarthy
Copy link
Author

Hi,

Sorry, should have included that.
Yes, It has compiled successfully without error after the modification was made.
I have compiled this version successfully and had it running as an iGate yesterday for a few hours of testing without issue.
I can see how much of a challenge it is to keep up with all the changes. It's not easy.
I really appreciate the time and effort that's been put into maintaining and improving direwolf over the years.
Thansk
Tom EI5IEB

@ra1nb0w
Copy link
Contributor

ra1nb0w commented Jul 25, 2022

FYI: with gpsd 3.24 you need GPSD_API_MAJOR_VERSION > 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants