"xterm" and BINARY_TERMINAL_BIN in direwolf.desktop are redundant #308
Assignees
Comments
classabbyamp
added a commit
to classabbyamp/direwolf
that referenced
this issue
May 16, 2022
fixes wb2osz#308 Per the [desktop entry specification](https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys), all that should be needed to run direwolf in the default terminal of a user's system should be setting `Terminal=true`. Per the [xdg icon theme specification](https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#icon_lookup), the `Icon` key in a desktop file should only include the basename of the icon's filename, not include the extension.
classabbyamp
added a commit
to classabbyamp/direwolf
that referenced
this issue
May 24, 2022
fixes wb2osz#308 Per the [desktop entry specification](https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys), all that should be needed to run direwolf in the default terminal of a user's system should be setting `Terminal=true`. Per the [xdg icon theme specification](https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#icon_lookup), the `Icon` key in a desktop file should only include the basename of the icon's filename, not include the extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
from my understanding, all that it takes for a program to run in a terminal from a .desktop file is
Terminal=true, but the direwolf.desktop file is instead usingTerminal=falseand defaults to launching xterm.Please consider simplifying by removing the BINARY_TERMINAL_BIN / APPLICATION_DESKTOP_EXEC logic.
Thanks!
(Spotted by lintian while updating the direwolf package in Debian. The move to cmake has let us drop lot of old extra packaging code, thanks!)
The text was updated successfully, but these errors were encountered: