Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.toml and Cargo.lock to 1.2.2 for 1.2.2 branch #186

Open
wants to merge 1 commit into
base: 1.2.2
Choose a base branch
from

Conversation

ajanon
Copy link
Collaborator

@ajanon ajanon commented Dec 20, 2022

Cargo.lock was updated using make release.

Please note that this PR is to be merged into the 1.2.2 branch. There will be a bit of divergence compared to the current main branch, but this allows us to make a proper fix release.

1.2.2 contains a number of fixes.
Below is a tentative release text for this version based in part on keep a changelog as discussed in #181:

1.2.2

Added

  • swhks debug command line option to get verbose logging
  • swhks log command line option to log to a file
  • swhkd-vim installs alongside swhkd in the AUR package

Changed

  • swhks no longer defaults to a verbose output (see debug flag)
  • swhks logs to a file by default
  • swhks now logs command output by default
  • man pages are now gzipped as part of the build process

Fixed

I am not 100% sure that the changelog above is accurate, feel free to discuss it.
Notably, I am not sure what 2832de8 is about. @EdenQwQ would you mind explaining it a bit for the changelog? Additionally, a2cdcee is quite large, and I am not sure if I understood all changes.

Cargo.lock was updated using `make release`.
@ajanon
Copy link
Collaborator Author

ajanon commented Dec 20, 2022

Before merging this, could we discuss a bit more the release message?

@Shinyzenith
Copy link
Member

a2cdcee

  • Removes multiple clippy warnings
  • Adds swhks logging of command outputs which defaults to "$(XDG_DATA_HOME)/swhks/swhks-$(CURRENT_UNIX_TIMESTAMP).log"
  • And finally add debug flag to swhks

Ah sorry for approving the pr first, I was typing this out 😅

@Shinyzenith
Copy link
Member

Apart from the commit eden made, the changelog looks fine. @EdenQwQ

@Shinyzenith
Copy link
Member

2832de8 I believe this commit fixes parsing of commands which are of the format command1 && command2? I'm not entirely sure but input from eden would help...sadly it looks like they're busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants