Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v2.ts #1214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update v2.ts #1214

wants to merge 1 commit into from

Conversation

elrumo
Copy link

@elrumo elrumo commented Mar 1, 2024

There was a missing '.ts' when importing lib/common, which gave a 'Cannot find module' when using the NPM package in a Nuxt 3 Vite. This solves the issue.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)
  • tests are included
  • documentation is changed or added
  • link to public docs when adding new a service or new features for an existing service
New version_date Checklist
  • A new constant is avaliable with the version_date - example
  • The new constant has a comment that summarizes the changes and/or links to relevant doc pages
  • Any older version_date constants remain intact
  • The error message thrown if the service is created without a version_date indicates the new version_date constant
  • The example in the README includes the new version_date constant
  • Any relevant code in the examples/ folder has been updated to use the new version_date constant
  • Most tests are updated to the new version_date
  • 1-2 new tests are added that use the old version_date (optional, but preferred)

There was a missing '.ts' when importing lib/common, which gave a 'Cannot find module' when using the NPM package in a Nuxt 3 Vite. This solves the issue.
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@apaparazzi0329
Copy link
Contributor

Can you send a link to an example Nuxt 3 Vite repo or tutorial you are using that is causing this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants