[ISSUE/348] Only display user-defined JS lint errors

[makinox]

Description

• Add ignore patterns to avoid non development errors and warnings
• Update package.json generator tests

Fixes # (348)

Type of change

• Code cleanup
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

[sodic]

Thanks for the PR @makinox!

This is a good approach, but there's one comment/request to be addressed before we merge the PR.

[sodic]

Good idea for a fix! I think this is the best short-term solution.

One important thing to note, however. The current approach assumes and hardcodes the ext-src inside the package.json file. Wasp's directory structure will most likely go through a lot of changes in the near future and we want to make sure this changes accordingly.

Ideally like to read and interpolate this path from a single source of truth (i.e., here). You can do this using the same templating system that's used for depsChunk and devDepsChunk. It involves editing a bit of Haskell code. Let me know if you need any help :)

[makinox]

Ok, on my way 🏃‍♂️

[makinox]

DONE ⚡️, I was going to reuse that path even more, but I watched in your code that you are not doing that with your path variables GeneratedExternalCodeDir, maybe there is a good reason that I don't know yet, let me know if this solves the issue 🫡😬

[sodic]

Thanks for the changes!

However, we already have an appropriate constant (source of truth) for this. I liked to it in the previous comment. Please use that one (you can move it to WebAppGenerator/Common).

but I watched in your code that you are not doing that with your path variables GeneratedExternalCodeDir

Not sure I got this. Can you elaborate and/or list an example?