Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Prisma update message #2005

Merged
merged 5 commits into from May 13, 2024
Merged

Hide Prisma update message #2005

merged 5 commits into from May 13, 2024

Conversation

infomiho
Copy link
Contributor

@infomiho infomiho commented May 3, 2024

Closes #1777

When testing locally, it's necessary to clear the Prisma telemetry cache so it outputs the message each time instead of caching the response: https://www.npmjs.com/package/checkpoint-client#clearing-the-cache

Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Looks quite good, but left a question.

waspc/ChangeLog.md Outdated Show resolved Hide resolved
waspc/src/Wasp/Generator/DbGenerator/Jobs.hs Outdated Show resolved Hide resolved
@infomiho infomiho requested a review from Martinsos May 8, 2024 10:10
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I left one comment, check it out and do with it as you like, I approved in any case.

waspc/cli/exe/Main.hs Outdated Show resolved Hide resolved
@infomiho infomiho force-pushed the miho-hide-prisma-update-message branch from 8884b7d to fd9dbdb Compare May 9, 2024 14:26
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@infomiho infomiho merged commit 676cf22 into main May 13, 2024
6 checks passed
@infomiho infomiho deleted the miho-hide-prisma-update-message branch May 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Prisma's "Update available" message
2 participants