Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Modify clangService.ts for multiple sources support #452

Closed
wants to merge 2 commits into from

Conversation

nokotan
Copy link

@nokotan nokotan commented Feb 20, 2020

Associated Issue: #365 #298

Here's the contributing guide at https://github.com/wasdk/WebAssemblyStudio/wiki/Contributing

Summary of Changes

  • change 1
    I have made changes to src/compilerServices/clangService.ts for the multiple files support.
    (almost same changes in Now We can Use Header File . #365; not updated for long time, I made this PR.)

Test Plan

Current test cases in tests/compilerServices/clangService.spec.ts are designed for single c source file and expected to rename this to "file.c", some test cases fail.
So I check my implementation manually... (should modify test cases, but I'm not sure that the modification is appropriate in this PR.)

Failing test cases:

  • should compile C/Cpp -> Wasm
  • should handle errors during compilation
  • should throw an error when trying to compile more than one file

Screenshots/Videos (OPTIONAL)

スクリーンショット 2020-02-20 15 50 27
スクリーンショット 2020-02-20 15 51 22
スクリーンショット 2020-02-20 15 51 38

@nokotan nokotan marked this pull request as draft February 21, 2021 03:42
@nokotan nokotan closed this Jun 13, 2021
@nokotan nokotan reopened this Jun 16, 2022
@nokotan nokotan closed this Jun 16, 2022
@nokotan nokotan deleted the cpp-multiple-files-support branch June 16, 2022 17:14
@nokotan
Copy link
Author

nokotan commented Jun 16, 2022

I've decided to rename branch, closing this issue.
Please refer #504.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant