Ipv6 support for provisioning nodes #1220
Conversation
The Ipaddr6 was not being read from the warewulf.conf Also the Ipv6 needed CIDR notation, which is not IP. Moved the check for the valid network from the IP address to the IPv6net option. This also should be set.
IPv6 ipaddr6 needed to be parsed differently at ":" then legacy IP.
Add Ipaddr6 as an option to the provisioning of nodes
Fix remote port.
|
Thanks for the PR, @dacianstremtan! I look forward to reviewing it. |
| @@ -29,10 +29,10 @@ type RootConf struct { | |||
| WWInternal int `yaml:"WW_INTERNAL"` | |||
| Comment string `yaml:"comment,omitempty"` | |||
| Ipaddr string `yaml:"ipaddr"` | |||
| Ipaddr6 string `yaml:"ipaddr6,omitempty"` | |||
| Ipaddr6 string `yaml:"Ipaddr6,omitempty"` | |||
| Netmask string `yaml:"netmask"` | |||
There was a problem hiding this comment.
I would like to keep ipaddr6 in the nodes.conf yaml file, as we have already ipaddr without capitalization.
There was a problem hiding this comment.
Unfortunately, when using the lower case "ipaddr6", the script (parser.go) is not picking up the Ipaddr6 declaration from the warewulf.conf file. It's being skipped. I did not know where this was declared to make sure that the case is ignored.
There was a problem hiding this comment.
the script
Which script? Or do you mean that a configured ipaddr6 value isn't actually available within Warewulf?
There was a problem hiding this comment.
The value ipaddr6 for the Warewulf controller node is not being picked up from the warewulf.conf
There was a problem hiding this comment.
I think we have the following situation, in warewulf.conf we use ipaddr6, but in all the templates (file ending with .ww it's Ipaddr6 as this is an exported variable in golang which must be capitalized.
We have similar problems for the variables in nodes.conf, but we might need to sync the variable names in the long run.
Description of the Pull Request (PR):
Write your description of the PR here. Be sure to include as much background,
and details necessary for the reviewers to understand exactly what this is
fixing or enhancing.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
git commit --signoff) in agreement to the DCO