Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding WAREWULF_OCI vars to wwctl #1142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mslacken
Copy link
Member

Its only possible to supply the credetials for a registry with the
the environment variables WAREWULF_OCI_USERNAME and
WAREWULF_OCI_PASSWORD which barely documented.
This PR add a command line parameters for wwctl container import

@mslacken mslacken added the enhancement New feature or request label Mar 18, 2024
@mslacken mslacken added this to the v4.5.1 milestone Mar 18, 2024
Signed-off-by: Christian Goll <cgoll@suse.com>
Copy link
Member

@JasonYangShadow JasonYangShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@anderbubble anderbubble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation for the environment variables and the new arguments.

@anderbubble anderbubble modified the milestones: v4.5.1, v4.6.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants