Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init to not require rootfs=initramfs to use tmpfs #1138

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anderbubble
Copy link
Collaborator

@anderbubble anderbubble commented Mar 16, 2024

Description of the Pull Request (PR):

Using SELinux requires setting root=tmpfs; but the implementation of /init also required rootfstype=ramfs unnecessarily.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

- Closes warewulf#1093

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
@anderbubble
Copy link
Collaborator Author

@mslacken I tried this out and it appears to work for me, which leaves me confused why it was this way in the first place. Let me know if you have any concerns.

@anderbubble anderbubble marked this pull request as draft March 17, 2024 23:14
@anderbubble
Copy link
Collaborator Author

I don't know why yet, but ever since I made this change I get inconsistent behavior about init starting correctly. Until I can sort that out, I'm marking this a draft.

Screenshot 2024-03-17 at 5 13 51 PM

@anderbubble
Copy link
Collaborator Author

See also #822

@anderbubble anderbubble modified the milestones: v4.5.1, v4.6.0 Apr 4, 2024
@anderbubble anderbubble modified the milestones: v4.6.0, v4.5.x Apr 27, 2024
@anderbubble anderbubble changed the title Update init to not require rootfs=initramfs to use tmpfs. Update init to not require rootfs=initramfs to use tmpfs May 1, 2024
@anderbubble anderbubble modified the milestones: v4.5.x, v4.5.2 May 1, 2024
@anderbubble anderbubble modified the milestones: v4.5.2, v4.5.3 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor wwinit/init script to resolve rootfs confusion
2 participants