Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container management functionality #1068

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mslacken
Copy link
Member

@mslacken mslacken commented Feb 1, 2024

Add a more advanved container management functionality to warewulf.
close #1067

@mslacken
Copy link
Member Author

mslacken commented Feb 2, 2024

@anderbubble @griznog This PR will add a

wwctl container reimport

command which will recreate a container from its original source. I think this useful, when you have messed your container installation process and want a fresh start. What do you think?
I implemented this more by accident as the cache is already in warewulf, so a reimport just pulls the old references.

@anderbubble
Copy link
Collaborator

I like the idea in theory; but how does it know what container to reimport from? What happens if the cache is cleared?

@mslacken
Copy link
Member Author

mslacken commented Feb 2, 2024

I like the idea in theory; but how does it know what container to reimport from?

At import time additional information is written to a meta file, so that the metainformation of the container is preserved

What happens if the cache is cleared?

An error! As a cache clearing mechanism isn't implemented, this is not really a problem.

My idea is, to also add the possibility to add new layers to cache, if a container is modified. This would make it possible to push/export containers back to a registry.

@anderbubble anderbubble added this to the v4.6.0 milestone Feb 17, 2024
@mslacken mslacken force-pushed the ContainerEnhancements branch 2 times, most recently from 2ef5494 to 346d2b9 Compare February 21, 2024 15:41
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>

	modified:   internal/pkg/container/imprt.go
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced container handling
2 participants