Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use templates for power calls #1004

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mslacken
Copy link
Member

@mslacken mslacken commented Dec 6, 2023

Refactor the wwctl power calls in such way that ipmitool is not hardcoded,
but is deducted from the ipmitool.tmpl which is located in the $DATADIR
This empowers users to have other memthods for the power managemnt like
freeipmi or redfish without touching the warewulf code itself. As an
example a template for power management without bmc is included.

  1. @anderbubble don't hit the merge button, because test coverage has
    increased a lot, but using the template is one of my best ideas in
    the last time
  2. @griznog we can use the template approach also for wwctl container copy
    so that on zfs pools the directory is cloned and on btrfs a cp --reflink=auto
    is used.

@griznog
Copy link
Contributor

griznog commented Dec 6, 2023

This is an awesome approach! I am very much in love with this idea and would like to see as many wwctl commands as possible have the option to be calls to a template.

@anderbubble anderbubble marked this pull request as draft December 6, 2023 16:36
@mslacken mslacken added this to the 4.6.0 milestone Dec 6, 2023
@anderbubble anderbubble added enhancement New feature or request and removed refactor labels Dec 7, 2023
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Signed-off-by: Christian Goll <cgoll@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants