Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added datacenter-gpu-manager package and updated base image location #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZAM-
Copy link

@ZAM- ZAM- commented May 10, 2024

No description provided.

@anderbubble anderbubble self-requested a review May 14, 2024 23:25
Copy link
Collaborator

@anderbubble anderbubble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZAM- can you make a couple small changes?

  • Sign-off on your commit (see git commit --signoff)
  • Move your new install command before the clean command

Make these changes in a single commit. See git commit --amend. After that you'll need to --force push to update your branch.

In the future I recommend making a PR from a new branch, rather than main, as it makes these kinds of updates a bit easier.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants