Add a validator on URL entity #6906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosomb
commented
Aug 29, 2023
| @@ -197,6 +197,8 @@ public function addEntryFormAction(Request $request, TranslatorInterface $transl | |||
| // entry saved, dispatch event about it! | |||
| $this->eventDispatcher->dispatch(new EntrySavedEvent($entry), EntrySavedEvent::NAME); | |||
|
|
|||
| return $this->redirect($this->generateUrl('homepage')); | |||
| } elseif ($form->isSubmitted() && !$form->isValid()) { | |||
| return $this->redirect($this->generateUrl('homepage')); | |||
There was a problem hiding this comment.
no need to have an error message here.
To be in this case, we have to change the type field via the web console (to have a text field, no more an URL one).
| if (\count($errors) > 0) { | ||
| $errorsString = (string) $errors; | ||
|
|
||
| return $this->sendResponse($errorsString); |
There was a problem hiding this comment.
not sure if I have to return the error like that.
| @@ -78,6 +78,9 @@ class Entry | |||
| * @var string | |||
| * | |||
| * @Assert\NotBlank() | |||
| * @Assert\Url( | |||
| * message = "The url '{{ value }}' is not a valid url", | |||
There was a problem hiding this comment.
I have to translate this message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6863