Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The URL is not checked before saving it #6863

Open
nicosomb opened this issue Aug 21, 2023 · 1 comment · May be fixed by #6906
Open

The URL is not checked before saving it #6863

nicosomb opened this issue Aug 21, 2023 · 1 comment · May be fixed by #6906
Labels
Bug

Comments

@nicosomb
Copy link
Member

When posting a new URL, we don't check if the URL is correct (by starting with https://..., etc). See https://www.php.net/manual/en/filter.filters.validate.php and FILTER_VALIDATE_URL.

This bug is available on API side and web side (because the only check is the <input type="url" ... you can easily bypass it).
@nicosomb nicosomb added the Bug label Aug 21, 2023
@tcitworld
Copy link
Member

Symfony's validator should make things easier than FILTER_VALIDATE_URL to handle punny code and restrict protocols.

@nicosomb nicosomb linked a pull request Aug 29, 2023 that will close this issue
Open
@nicosomb nicosomb linked a pull request Aug 29, 2023 that will close this issue
Add a validator on URL entity #6906
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a validator on URL entity wallabag/wallabag
2 participants
@nicosomb @tcitworld