Add settings to control language prefix #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evyd13
added a commit
to evyd13/wagtailtrans
that referenced
this pull request
May 4, 2021
evyd13
added a commit
to evyd13/wagtailtrans
that referenced
this pull request
May 22, 2021
This reverts commit a14be63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, there is a space for improvements with how wagtailtrans handles language prefixes in path. The improvements I'd like to introduce are described as well in #169 and #184.
With this change I'd like to introduce settings that allow to control the language prefix visible in the URL bar. Here are my objectives:
/news/) and make sure wagtailtrans will redirect user to a correct language version of the page based on the request's language (e.g./en/news).en) without specifying the language prefix (e.g. access/news/instead of/en/news). In such situation the page should be served immediately without a redirection.In my opinion these changes are related to each other and that's why I'm proposing a single change instead of splitting it into two.
I'd be grateful for your opinion in this matter and some help with improving the code.