Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semgrep is quite slow compared to our other pre-commit hooks, taking around 2 seconds to complete on my machine. Try to improve this a bit by:
We're currently only using semgrep to enforce old-style string formatting on translation strings, which comes up infrequently enough that we might want to consider leaving this out of pre-commit and just relying on CircleCI to catch it instead. Will see how this improvement pans out first, though...