Downgrade 'Unable to find purge backend' messages to info #11899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://gasmanadminmake-frontend-cache-txcqk.squash.io |
RealOrangeOne
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11858 has made test output very noisy, because the
wagtail.contrib.frontend_cacheapp is enabled inINSTALLED_APPSbut has no backends defined (by default - these are added for individual tests viaoverride_settings) - consequently, any publish/unpublish action in the regular tests produces a warning "Unable to find purge backend for localhost".I've chosen to downgrade this to an "info" message, since warnings are generally reserved for configurations that are "wrong but recoverable" - there are potentially valid reasons to have a frontend cache configured for some but not all hostnames, so it's not inherently something that needs developer attention.