New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon alignment in page listings #11870
Conversation
Manage this branch in SquashTest this branch here: https://laymonagefix-page-listing-icon-01lce.squash.io |
50ddaf7
to
9d40ca1
Compare
The second commit fixes #11875. (Not exactly the same as it was in 6.0 but if we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just the one change needed; will tweak and merge.
@@ -4,6 +4,7 @@ | |||
border-radius: 2px; | |||
text-align: center; | |||
display: inline-block; | |||
flex-shrink: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed we’ll change this to word-break: normal
to fix #11875 while reducing the risk of page titles being squashed by long locale names (Portuguese (Brazil) (latest)
).
This was added in f322e9d, when the snippets listing view was briefly redesigned to put the "Edit", "Delete" etc. actions in the same line as the title instead of in a new line. With the universal listings design, all listing actions are put inside a three-dot dropdown menu. This style is no longer used anywhere in Wagtail, especially now that the HistoryView has been reimplemented using the dropdown menu for the actions.
2aa6475
to
5927b12
Compare
display: flex; | ||
align-items: center; | ||
justify-content: space-between; | ||
gap: theme('spacing.2'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes an issue on Safari introduced in bb12877, while also improving the alignment of the site/folder icon on other browsers. The second commit fixes #11875.
Safari before/after
Screenshots
Chrome before/after
Screenshots
Firefox before/after
Screenshots