Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated a circle border on the brand logo #11721

Conversation

nandini584
Copy link
Contributor

Fixes #11449

I have made some improvements to the design for Menu and Menu-Items.
The border was added to the brand logo and extra 3px margins were removed from both left and right.

Copy link

squash-labs bot commented Mar 4, 2024

Manage this branch in Squash

Test this branch here: https://nandini584menu-and-menu-items-xijac.squash.io

@lb-
Copy link
Member

lb- commented Mar 4, 2024

Thanks for taking the time to prepare this PR @nandini584 do you mind including a screenshot of before/after in your PR description - it will help with reviewing.

Also, a reminder to run your formatter on any new code changes. npm run format should fix this, or you can look at installing the pre-commit hooks. https://docs.wagtail.org/en/stable/contributing/developing.html#automatically-lint-and-code-format-on-commits

@nandini584
Copy link
Contributor Author

nandini584 commented Mar 8, 2024

I had some problem with my previous repo throwing an error so I had to reclone it and create another pr,
#11741
Screenshot 2024-03-08 194509

I have updated the changes and added screenshots as per requirement and have used forced colors as well.

@lb-
Copy link
Member

lb- commented Mar 10, 2024

Ok. I'll assume this PR can be closed then as #11741 is the newer one.

@lb- lb- closed this Mar 10, 2024
@nandini584
Copy link
Contributor Author

Yup thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contrast themes / WHCM support improvements
2 participants